fix: no-invalid-properties false positives for var() in functions #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
nzakas
reviewed
Aug 4, 2025
lumirlumir
added
the
accepted
|
Can you check the test failures? |
snitin315
reviewed
Aug 30, 2025
snitin315
requested changes
Aug 30, 2025
There was a problem hiding this comment.
We have one false positive, can you please check?
/* eslint css/no-invalid-properties: "error" */
:root {
--dynamic-width: calc(20px + 10px);
--dynamic-width-2: calc(var(--dynamic-width) + 10px);
}
.div { width: calc(100% - var(--dynamic-width)); } // ok
.div2 { width: calc(100% - var(--dynamic-width-2)); } // Error Unknown property 'width' found
|
@snitin315 I looked into it but wasn't able to reproduce the false positive. To be thorough, I've added a test case for this scenario, and it's currently passing. |
snitin315
approved these changes
Sep 23, 2025
github-project-automation
bot
moved this from Second Review Needed
to Complete
in Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This PR fixes a regression in the
no-invalid-propertiesrule where it incorrectly reports for valid CSS properties containingvar()usage within functions likecalc().What changes did you make? (Give an overview)
Related Issues
Fixes #223
Is there anything you'd like reviewers to focus on?